[6.2][ScanDependencies] Fix a bug in rewrite from #81454 #82642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When improving the speed of dependency scanning when the new clang API to speed up bridging, some unintended change was introduced. This restore the scanner to the behavior before swiftlang#81454 rdar://153851818 (cherry picked from commit cebe173)
Contributor
Author
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 30, 2025
Contributor
nkcsgexi
left a comment
nkcsgexi
left a comment
There was a problem hiding this comment.
Preserving additional compiler arguments when scanning dependencies should be a safe change.
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-ivfsoverlayarguments are dropped from-emit-pcmjobs. This can sometimes cause build failure due to VFS overlay are not overlaying existing files on the file system.