Skip to content

Conversation

charles-zablit
Copy link
Contributor

#82188 made WINDOWS_SDKS an env variable to configure which Sdks should be built.

This patch ensures that we set WINDOWS_SDKS even if the script was called from a Visual Studio shell, which is the case in CI.

@charles-zablit charles-zablit requested a review from compnerd as a code owner June 30, 2025 16:20
@charles-zablit charles-zablit self-assigned this Jun 30, 2025
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems safe. We should try to get the job configuration to remove the VSDevCmd setup - it would save a few seconds and simplify the build-windows-toolchain.bat script.

@charles-zablit charles-zablit enabled auto-merge June 30, 2025 16:32
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test macOS

@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit merged commit f2d9de9 into swiftlang:main Jul 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants