Cherry-pick [Swiftify] Don't import counted_by with suffixed integer literals (#82469) #82594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iftlang#82469) Integer literal expressions with types that are not of type `int` are printed with a suffix to indicate the type (e.g. `123U` or `456L` for `unsigned` and `long`). This is not valid syntax for integer literals in Swift, so until we fully translate the count expr syntax to Swift we need to avoid importing these count expressions. Also fixes some -Werror related stuff in test cases. rdar://154141719 (cherry picked from commit 374658a)
Member
Author
|
@swift-ci please test |
j-hui
approved these changes
Jun 28, 2025
Member
Author
|
@swift-ci please test macos |
1 similar comment
Member
Author
|
@swift-ci please test macos |
DougGregor
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C/C++ integer literal expressions with types that are not of type
intare printed with a suffix to indicate the type (e.g.123Uor456Lforunsignedandlong). This is not valid syntax for integer literals in Swift, so until we fully translate the count expr syntax to Swift we need to avoid importing these count expressions.This patch skips attaching a macro in cases where it would previously cause a compilation error, which practically corresponds when an integer literal (or constant folded integer expression) has a type that isn't
int- e.g.char,short,unsigned,longetc.rdar://154141719
[Swiftify] Don't import counted_by with suffixed integer literals #82469
Low
Added regression tests
@Xazax-hun
@j-hui