[6.2] [SILGen] Ensure that we don't emit a skipped isolated deinit #82546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://154373088 / issue swiftlang#82523
Member
Author
|
@swift-ci please test |
ktoso
approved these changes
Jun 26, 2025
bnbarham
approved these changes
Jun 26, 2025
Member
Author
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deinitwith Objective-C-derived classes would crash when generating a Swift module, because SILGen would attempt to emit the definition even when it was deliberately skipped. Align the logic here so we don't emit the definition when it's not needed.nonisolated deinitfeature.