remote-run: Find rsync #82503
Merged
remote-run: Find rsync #82503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current remote-run implementation only works if rsync is located at `/usr/bin/`, which isn't always the case. FreeBSD installs rsync to `/usr/local/bin` as it is not installed in the base system by default. Relax the script to accept rsync on any path.
remote-run uses rsync instead of sftp server. Some of the tests were incorrectly labelled as requiring sftp server. Fixed those and replaced the requirement with rsync.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD installs rsync to
/usr/local/bininstead of/usr/bin, which caused the remote-run tests to fail when they should have run fine becausersyncwas installed.remote-runshould be able to grab anrsyncon the path if it exists.Also replacing the
sftp_serverin the available features withrsyncand migrated the remote-run tests off of requiring ansftp_serversince the tests no longer use it.