[test] Fix or disable tests for 32-bit platforms

[finagolfin]

Fix one PCM and two IRGen tests that are failing on Android armv7 and disable two SILOptimizer tests that were already failing on other 32-bit platforms.

As part of the upcoming official Android SDK bundle, #80788, we're running the non-executable compiler validation suite for Android armv7 again before including the armv7 Swift stdlib, and I see 10 tests failing in both the trunk 6.3 and 6.2 branches.

This pull fixes or disables half of them, whereas the other half are all C++ Interop constructor tests that fail because they cannot build that C module with size_t issues:

<unknown>:0: error: fatal error encountered while in -verify mode
/home/finagolfin/swift/test/Interop/Cxx/class/constructors-typechecker.swift:3:8: error: unexpected error produced: could not build C module 'Constructors'
import Constructors
       ^
/home/finagolfin/swift/test/Interop/Cxx/class/constructors-typechecker.swift:11:51: error: expected warning not produced
let deletedImplicitly = ConstructorWithParam() // expected-warning {{'init()' is deprecated}}
                                              ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<--- snip irrelevant errors --->
/home/finagolfin/swift/test/Interop/Cxx/class
/home/finagolfin/swift/test/Interop/Cxx/class/Inputs/constructors.h:253:9: error: diagnostic produced elsewhere: 'operator new' takes type size_t ('unsigned int') as first parameter
  void *operator new(size_t, void *ptr) { return ptr; }
        ^
<module-includes>:1:10: note: diagnostic produced elsewhere: in file included from <module-includes>:1:
#include "constructors.h"
         ^
/home/finagolfin/swift/test/Interop/Cxx/class/Inputs/constructors.h:263:8: warning: diagnostic produced elsewhere: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)
  void *operator new(size_t);
       ^
/home/finagolfin/swift/test/Interop/Cxx/class/Inputs/constructors.h:263:8: note: diagnostic produced elsewhere: insert '_Nullable' if the pointer may be null
  void *operator new(size_t);
       ^
/home/finagolfin/swift/test/Interop/Cxx/class/Inputs/constructors.h:263:8: note: diagnostic produced elsewhere: insert '_Nonnull' if the pointer should never be null
  void *operator new(size_t);
       ^
<module-includes>:1:10: note: diagnostic produced elsewhere: in file included from <module-includes>:1:
#include "constructors.h"
         ^
/home/finagolfin/swift/test/Interop/Cxx/class/Inputs/constructors.h:263:9: error: diagnostic produced elsewhere: 'operator new' takes type size_t ('unsigned int') as first parameter
  void *operator new(size_t);
        ^

@egorzhdan or @fahadnayyar, any idea what that 32-bit C++ Interop issue is or should I just disable those five tests for Android armv7?

[finagolfin]

The issue is that the target triple is armv7-unknown-linux-androideabi, while the Swift compiler passes along the slightly different module triple armv7-unknown-linux-android to the ClangImporter. I think some other platforms have similar differences, so I don't know why this would be failing on Android armv7 alone, unless it really is the only one on the official CI that varies like this.

[finagolfin]

This fix failed on macOS, as it passes the full x86_64-apple-macosx13.0 triple to the ClangImporter, not the abbreviated module triple x86_64-apple-macos like Android armv7 does. Since these platforms are doing different things, simply disabled this test for Android armv7 for now.

[finagolfin]

Android armv7 generated define internal void @makeOne(ptr dead_on_unwind noalias writable sret(%struct.One) align 4 %agg.result, float noundef %f, float noundef %s) in its IR instead, so I added those attributes, optionally since I don't know if they will be there on other armv7 platforms.

[kateinoigakukun]

It looks like Clang adds dead_on_unwind for sret args, so they always appear in a combination. I guess we don't need to make it optional. https://github.com/swiftlang/llvm-project/blob/f1607d165cb61ef9f857d76afc6e8a04345bb41a/clang/lib/CodeGen/CGCall.cpp#L2622

[finagolfin]

OK, do you mind approving this pull as is? Don't want to kick off another CI run just for this, and keeping it optional is more flexible anyway.

[finagolfin]

llvm-cxxfilt _ZnwjPv15container_new_t demangles this to operator new(unsigned int, void*, container_new_t), in addition to the operator new(unsigned long, void*, container_new_t) that was already there for 64-bit platforms.

[finagolfin]

@swift-ci smoke test

[finagolfin]

@swift-ci smoke test macos

[finagolfin]

Simply disabled the five failing C++ Interop tests and the ClangImporter test for Android armv7 and rebased.

[finagolfin]

@swift-ci smoke test

[finagolfin]

@swift-ci smoke test macos

[finagolfin]

@kateinoigakukun, mind reviewing the two IRGen changes? The rest are just disabling tests for Android armv7, so should be fine.