Enable more tests for Embedded Wasm #82399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test linux |
1 similar comment
Contributor
Author
|
@swift-ci smoke test linux |
MaxDesiatov
requested review from
bnbarham,
eeckstein,
kateinoigakukun,
kubamracek and
rauhul
MaxDesiatov
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
MaxDesiatov
added
test suite
Contributor
Author
|
@swift-ci smoke test |
1 similar comment
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
kubamracek
reviewed
Jun 24, 2025
kubamracek
reviewed
Jun 24, 2025
MaxDesiatov
force-pushed
the
maxd/embedded-wasm-tests
branch
from
50f4eaf to
2c391e4
Compare
Contributor
Author
|
@swift-ci smoke test |
kubamracek
reviewed
Jun 27, 2025
kubamracek
approved these changes
Jun 27, 2025
Contributor
|
LGTM, and thanks! |
There's a predefined list of supported platforms that WASI should be added now that it has an official Embedded Swift SDK.
The overall change should be only localized to executable tests for now.
MaxDesiatov
force-pushed
the
maxd/embedded-wasm-tests
branch
from
20ace90 to
db33d70
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
1 similar comment
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci test windows |
7 similar comments
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
@swift-ci test windows |
MaxDesiatov
added a commit
that referenced
this pull request
Jul 26, 2025
Cherry-pick of #83128, #82399, and #82878, merged as ea6ca2b, 0c4e561, and e34eb33 respectively. **Explanation**: Currently `test/CMakeLists.txt` can only set `SWIFT_LIT_ARGS` for all tests uniformly. This means that we can't have tests for Embedded Swift with a different set of `lit.py` arguments. Also, create new `check-swift-embedded-wasi` target from `test/CMakeLists.txt`, tweak `lit.cfg` to support WASI Clang resource dir, exclude unsupported tests based on `CPU=wasm32` instead of `OS=wasi`. **Scope**: Limited to Embedded Swift test suite. **Risk**: Low, due to limited scope. **Testing**: #82878 was incubated on `main` for 2 weeks, #82399 for 3 weeks with no disruption, #83128 merged this week, but enables all these tests on CI, which are consistently passing. **Issue**: rdar://156585717 **Reviewer**: @bnbarham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests still require a manual
lit.pyinvocation for Wasm, which will be added as a separate CMake target in a future PR.