Skip to content

[stdlib, 6.2] revert "add missing computed properties" #82284 #82351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[stdlib, 6.2] revert "add missing computed properties" #82284 #82351

merged 1 commit into from
Jun 20, 2025

Conversation

@glessard
Copy link
Contributor

@glessard glessard commented Jun 18, 2025 •
edited
Loading

This PR produces a change in the swiftinterface file that is incompatible with older compilers, and causes the oss-swift-6.2-test-stdlib-with-toolchain CI bot to fail.

Reverting this change until we can guard it with a feature flag (or another solution.)

Addresses rdar://153752588

@glessard
Revert "Merge pull request swiftlang#82284 from glessard/rdar15321917…
9de7018 
…4-UMBP-mutableSpan-62"

This reverts commit 845b68a, reversing
changes made to 3d1c592.
@glessard glessard requested a review from a team as a code owner June 18, 2025 21:08
@glessard
Copy link
Contributor Author

glessard commented Jun 18, 2025

@swift-ci please test

@glessard glessard enabled auto-merge June 18, 2025 21:48
@glessard glessard disabled auto-merge June 18, 2025 22:33
@atrick
Copy link
Contributor

atrick commented Jun 18, 2025

oss-swift-6.2-test-stdlib-with-toolchain is not a supported configuration. We should make sure this is a real problem before reverting it.

@atrick
Copy link
Contributor

atrick commented Jun 20, 2025

This is a real problem: recent compilers cannot recompile the newly generated Swift.swiftinterface. I'm working on a compiler flag that would fix this by automatically disable the new APIs, but still debugging it.

@glessard glessard merged commit f589a7f into swiftlang:release/6.2 Jun 20, 2025
5 checks passed
@atrick
Copy link
Contributor

atrick commented Jun 20, 2025

UMP.mutableSpan can be reapplied with the following feature guard:
6.2 PR: #82381
main PR: #82380

@atrick atrick mentioned this pull request Jun 20, 2025
Merged
@glessard glessard deleted the rdar153219174-UMBP-mutableSpan-62 branch June 23, 2025 18:22
@glessard glessard mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glessard @atrick @stephentyrone