[cxx-interop] Make usages of Swift Span @_alwaysEmitIntoClient in the overlay
#82309
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he overlay This fixes a regression where projects that use the C++ stdlib overlay stop building because of a linker error: ``` ld: Shared cache eligible dylib cannot link to ineligible dylib '@rpath/libswiftCompatibilitySpan.dylib'. ``` Usages of `Span<T>` would generally cause a type metadata accessor to be emitted for `Swift.Span`. This becomes a problem with backdeployment, since Span is partially defined in a compatibility binary. This change adds `@_alwaysEmitIntoClient` to generic usages of `Span` to prevent the type metadata accessor from being emitted into `libswiftCxx.a`. rdar://152192080
egorzhdan
requested review from
Xazax-hun,
fahadnayyar,
j-hui,
susmonteiro and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please test |
slavapestov
approved these changes
Jun 17, 2025
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
LGTM! Hopefully it fixes the problem we're seeing (and if not, it's a good change anyway)
Xazax-hun
approved these changes
Jun 17, 2025
glessard
approved these changes
Jun 17, 2025
j-hui
approved these changes
Jun 18, 2025
Contributor
Author
|
@swift-ci please smoke test macOS |
Contributor
Author
|
@swift-ci please smoke test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test Windows |
Contributor
Author
|
@swift-ci please smoke test Windows |
Xazax-hun
pushed a commit
that referenced
this pull request
Jun 24, 2025
The underlying issue was fixed in #82309 rdar://149402670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where projects that use the C++ stdlib overlay stop building because of a linker error:
Usages of
Span<T>would generally cause a type metadata accessor to be emitted forSwift.Span. This becomes a problem with backdeployment, since Span is partially defined in a compatibility binary.This change adds
@_alwaysEmitIntoClientto generic usages ofSpanto prevent the type metadata accessor from being emitted intolibswiftCxx.a.rdar://152192080