Skip to content

Conversation

@xedin
Copy link
Contributor

@xedin xedin commented Jun 16, 2025

Cherry-pick of #82229


  • Explanation:

    Prevents nonisolated(nonsending) feature migration from applying to @Test annotated and compiler/macro synthesized declarations.

    • @Test asynchronous functions

      The execution of these functions is controlled by the testing
      framework and it's okay if their behavior changes when the feature
      flag is enabled.

    • $ prefix functions declarations

      These are special declarations that are synthesized by the compiler
      or a macro and warnings about them are non-actionable.

  • Resolves: rdar://152687527

  • Main Branch PR: [Concurrency] NonisolatedNonsendingByDefault: Except @Test test-cases and $ prefixed declarations from migration #82229

  • Risk: Very Low. The change applies to migration mode of the feature that is not enabled by default.

  • Reviewed By: @grynspan @stmontgomery @AnthonyLatsis

  • Testing: No testing since it's a framework/synthesis specific change that is hard to unit test.

xedin added 2 commits June 16, 2025 13:44
…e swift-testing test cases

The execution of these functions is controlled by the testing
framework and it's okay if their behavior changes when the feature
flag is enabled.

Resolves: rdar://152687527
(cherry picked from commit f2f5d23)
…e `$` prefixed declarations

These are special declarations that are synthesized by the compiler
or a macro and warnings about them are non-actionable.

(cherry picked from commit 17976c7)
@xedin xedin requested a review from a team as a code owner June 16, 2025 20:48
@xedin xedin added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 16, 2025
@xedin
Copy link
Contributor Author

xedin commented Jun 16, 2025

@swift-ci please test

@xedin xedin merged commit 2e18973 into swiftlang:release/6.2 Jun 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants