[6.2][IRGen] Emit null check before swift_conformsToProtocol for nullable metatypes #82241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drexin
commented
Jun 13, 2025
drexin
commented
- Explanation: swift_conformsToProtocol does not properly handle nullptr values, which can currently be passed if the source type is an optional metatype. This change adds emission of a null check before calling the runtime function in these cases.
- Scope: IRGen for checked casts
- Issues: rdar://149882902
- Original PRs: [IRGen] Emit null check before swift_conformsToProtocol for nullable … #82240
- Risk: Low. This change only affects the specific case that currently causes issues. Other instances should not be affected.
- Testing: Added a regression test
- Reviewers: @aschwaighofer @mikeash
drexin
changed the title
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Jun 13, 2025
…metatypes rdar://149882902 swift_conformsToProtocol does not properly handle nullptr values, which can currently be passed if the source type is an optional metatype. This change adds emission of a null check before calling the runtime function in these cases.
drexin
force-pushed
the
wip-149882902-6.2
branch
from
327722c to
533e215
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.