[6.2][TypeCheckEffects] Fix AbstractFunction::getType to look through al…
#82130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l levels of optional A member and a parameter could be wrapped in an arbitrary number of `Optional`, we need to look through all of them to get to the underlying function type. Resolves: rdar://151943924 (cherry picked from commit 86390ab)
xedin
changed the title
AbstractFunction::getType to look through al…AbstractFunction::getType to look through al…
bnbarham
approved these changes
Jun 10, 2025
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l levels of optional
Cherry-pick of #81852
Explanation:
A member and a parameter could be wrapped in an arbitrary number of
Optional, we need to look through all of them to get to the underlying function type.Resolves: rdar://151943924
Main Branch PR: [TypeCheckEffects] Fix
AbstractFunction::getTypeto look through al… #81852Risk: Low. This is a narrow fix that affects only declaration references with two or more levels of optional that require effects checking.
Reviewed By: @DougGregor
Testing: Added new test-cases to the test suite.
(cherry picked from commit 86390ab)