[ClangImporter] SE-0463: Implement @Sendable inference exception for global actor isolated functions
#82085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter This lifts the check for the feature flag up into the `importParameterType` from `importType` and means that completion handler type for `async` variant is no longer gains `@Sendable` attribute.
xedin
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
jckarter,
ktoso,
susmonteiro and
zoecarver
as code owners
ktoso
approved these changes
Jun 7, 2025
Contributor
Author
|
@swift-ci please test |
…r global actor isolated functions Functions that are isolated to a global actor don't have completion handlers imported as `@Sendable`. Main actor isolated functions with completion handlers that are always called on the main actor is a very common Objective-C pattern, and this carve out will eliminate false positive warnings in the cases where the main actor annotation is missing on the completion handler parameter. Resolves: rdar://149811049
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test Linux platform |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test Linux platform |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
4 similar comments
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 1, 2025
…s of imported APIs should match This is a follow-up to swiftlang#82085 which made it so async variant doesn't get `@Sendable` inferred because the proposal specified that inference should happen only on completion handler parameter type of a synchronous variant of an imported API. This runs into implementation issues related to thunking in some cases were async convention expects the type of a completion handler to match exactly for both variants of the imported API. Resolves: rdar://154695053
xedin
added a commit
to xedin/swift
that referenced
this pull request
Jul 1, 2025
…s of imported APIs should match This is a follow-up to swiftlang#82085 which made it so async variant doesn't get `@Sendable` inferred because the proposal specified that inference should happen only on completion handler parameter type of a synchronous variant of an imported API. This runs into implementation issues related to thunking in some cases were async convention expects the type of a completion handler to match exactly for both variants of the imported API. Resolves: rdar://154695053 (cherry picked from commit 30f0fa8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that are isolated to a global actor don't have completion
handlers imported as
@Sendable. Main actor isolated functions withcompletion handlers that are always called on the main actor is a
very common Objective-C pattern, and this carve out will eliminate
false positive warnings in the cases where the main actor annotation
is missing on the completion handler parameter.
Resolves: rdar://149811049