line-directive: Stop expanding response files #81996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`line-directive` was expanding response files for the swiftc invocation, which was causing issues on CI when the file list got too long. This changes the script to stop expanding response files and pass them as-is to the swiftc invocation instead. The format for the response files was also incorrect, with each individual file being quoted, so this fixes the CMake script generating those. Finally, this changes `line-directive` to dump the command line on failure.
Member
|
@swift-ci please smoke test |
etcwilde
approved these changes
Jun 4, 2025
Member
|
@swift-ci please smoke test macOS platform |
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jun 5, 2025
The changes in swiftlang#81996 fixed the response file format but failed to actually make `line-directive` stop expanding the response files in the compiler invocation. These changes fix that.
Steelskin
pushed a commit
to Steelskin/swift
that referenced
this pull request
Jun 10, 2025
…ive-stop-expanding-rsp line-directive: Stop expanding response files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line-directivewas expanding response files for the swiftc invocation, which was causing issues on CI when the file list got too long. This changes the script to stop expanding response files and pass them as-is to the swiftc invocation instead. The format for the response files was also incorrect, with each individual file being quoted, so this fixes the CMake script generating those.Finally, this changes
line-directiveto dump the command line on failure.