[IDE] Pass a SourceRange instead of a CharSourceRange in SemaAnnotator::passReference
#81975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
artemcm,
bnbarham,
hamishknight,
nkcsgexi,
rintaro and
tshortli
as code owners
Member
Author
|
@swift-ci Please smoke test |
…otator::passReference` Most `SemaAnnotator`s don’t actually care about the char source range. Instead, they only care about the start location of the reference, which is also included in `SourceRange`. Computing a `CharSourceRange` from a `SourceRange` is kind of expensive because it needs to start a new lexer. To avoid this overhead, pass `SourceRange` to `SemaAnnotator::passReference` and related functions and let the clients compute the `CharSourceRange` when needed. This reduces the overhead of index-while-building by about 10%.
ahoppen
force-pushed
the
sema-annotate-source-range
branch
from
cd19463 to
c6c40de
Compare
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Jun 4, 2025
| assert(Range.getByteLength() > 3); | ||
| assert(Range.str().starts_with("`_") || | ||
| Range.str().starts_with("`$")); | ||
| CharSourceRange CharRange = Lexer::getCharSourceRangeFromSourceRange( |
Contributor
There was a problem hiding this comment.
Does VD not have its name?
| D->getASTContext().SourceMgr, Range); | ||
| if (SeenDecls.insert(D).second) | ||
| tryDemangleDecl(D, Range, /*isRef=*/true); | ||
| tryDemangleDecl(D, CharRange, /*isRef=*/true); |
Contributor
There was a problem hiding this comment.
Doesn't really matter since this is swift-ide-test, but looks like tryDemangleDecl only uses the range to get the name again 🤷
bnbarham
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
SemaAnnotators don’t actually care about the char source range. Instead, they only care about the start location of the reference, which is also included inSourceRange. Computing aCharSourceRangefrom aSourceRangeis kind of expensive because it needs to start a new lexer.To avoid this overhead, pass
SourceRangetoSemaAnnotator::passReferenceand related functions and let the clients compute theCharSourceRangewhen needed.This reduces the overhead of index-while-building by about 10%.