[Dependency Scanning] Bridge diagnostics emitted during bridging header scanning #81850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
May 29, 2025
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
LGTM.
I think we should still leave a TODO or have an issue tracking if we can really bridging the source location as well.
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
FYI, if you try a chain bridging header option, this is going to leave multiple error outputs, I don't know if this is also something we need to fix...
artemcm
force-pushed
the
BridgeHeaderScanDiagnostics
branch
from
8d71f1c to
e9f2232
Compare
Contributor
Author
|
@swift-ci smoke test |
…er scanning Instead of simply dumping them to stderr. Resolves rdar://151993075
artemcm
force-pushed
the
BridgeHeaderScanDiagnostics
branch
from
e9f2232 to
8ec341e
Compare
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simply dumping them to stderr.
Resolves rdar://151993075