Skip to content

[6.2] DeadStoreElimination: don't assume that the operand of an dealloc_stack is an alloc_stack. #81735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025
Merged

[6.2] DeadStoreElimination: don't assume that the operand of an dealloc_stack is an alloc_stack. #81735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SwiftCompilerSources/Sources/Optimizer/FunctionPasses/DeadStoreElimination.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ private extension Deallocation {

private extension DeallocStackInst {
func isStackDeallocation(of base: AccessBase) -> Bool {
if case .stack(let allocStack) = base, allocstack == allocStack {
if case .stack(let allocStack) = base, operand.value == allocStack {
return true
}
return false
Expand Down
6 changes: 1 addition & 5 deletions SwiftCompilerSources/Sources/SIL/Instruction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,11 +647,7 @@ extension Deallocation {
}


final public class DeallocStackInst : Instruction, UnaryInstruction, Deallocation {
public var allocstack: AllocStackInst {
return operand.value as! AllocStackInst
}
}
final public class DeallocStackInst : Instruction, UnaryInstruction, Deallocation {}

final public class DeallocStackRefInst : Instruction, UnaryInstruction, Deallocation {
public var allocRef: AllocRefInstBase { operand.value as! AllocRefInstBase }
Expand Down