[Compile Time Values] Add syntactic verification of valid expressions in @const contexts
#81510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
DougGregor,
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
|
Woohoo! |
slavapestov
reviewed
May 15, 2025
artemcm
force-pushed
the
ConstSyntacticVerify
branch
from
4280f55 to
df1eef9
Compare
artemcm
requested review from
CodaFi,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
|
This is very cool! |
Contributor
|
@swift-ci test |
artemcm
force-pushed
the
ConstSyntacticVerify
branch
from
df1eef9 to
30afce2
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
ConstSyntacticVerify
branch
from
30afce2 to
d8176a7
Compare
Contributor
Author
|
@swift-ci test |
kubamracek
reviewed
May 20, 2025
| @const let constGlobal5: (Int, Float) = (42, 42.0) | ||
| @const let constGlobal7: (UInt64, StaticString, @convention(c) ()->Int) = (42, "hi", { return 42 }) | ||
|
|
||
| // Closure call not supported in syntactically-validated mode |
Contributor
There was a problem hiding this comment.
nit: this is not a closure call, but just a closure reference
kubamracek
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntactically verify that initializer expressions of
@constvariables and argument expressions to@constparameters consist strictly of syntactically-verifiable set of basic values and operations.Adds experimental feature
CompileTimeValuesPreviewwhich will disable syntactic verification and leave the contents of@constexpressions up to downstream evaluation capabilities.