[presets] Escalate C++ "unused" warnings in macOS smoke test #81284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
hborla,
rjmccall,
slavapestov and
xedin
as code owners
Collaborator
Author
|
@swift-ci please smoke test macOS |
edymtt
approved these changes
May 7, 2025
Contributor
edymtt
left a comment
edymtt
left a comment
There was a problem hiding this comment.
Looks good to me with regard to CMake and preset changes.
AnthonyLatsis
force-pushed
the
no-warnings-asserts
branch
from
5f7b588 to
9a1995a
Compare
Collaborator
Author
|
@swift-ci please smoke test macOS |
AnthonyLatsis
force-pushed
the
no-warnings-asserts
branch
from
9a1995a to
e7237fd
Compare
Collaborator
Author
|
@swift-ci please smoke test macOS |
Collaborator
Author
|
@swift-ci please smoke test |
AnthonyLatsis
added a commit
to AnthonyLatsis/swift
that referenced
this pull request
Jul 29, 2025
AnthonyLatsis
added a commit
that referenced
this pull request
Jul 31, 2025
[presets] Actually make #81284 work
Contributor
|
Thank you 🙏. I'm looking forward to us adding more warnings to this list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modest attempt to make our builds more warning-free. Over time, we can add more warning groups and extrapolate this to Swift sources.