[6.2] CastOptimizer: don't assume dynamic casts from ObjectiveC classes to unrelated classes will fail #81251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
May 2, 2025
eeckstein
commented
- Explanation: In case of ObjectiveC classes, the runtime type can differ from its declared type. Therefore a cast between (compile-time) unrelated classes may succeed at runtime. It turned out that this kind of runtime vs. formal type mismatch appears quite often in real world code. This change disables ObjectiveC class casts in the cast optimizer which makes the generated code in release builds behave the same way as in debug builds.
- Risk: low: It's a simple change which cast optimizer more conservative when dealing with ObjectiveC classes.
- Testing: Tested by lit tests
- Issue: rdar://149810124
- Reviewer: @mikeash , @tbkka
- Main branch PR: CastOptimizer: don't assume dynamic casts from ObjectiveC classes to unrelated classes will fail #81203
…unrelated classes will fail In case of ObjectiveC classes, the runtime type can differ from its declared type. Therefore a cast between (compile-time) unrelated classes may succeed at runtime. rdar://149810124
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test linux |
1 similar comment
Contributor
Author
|
@swift-ci test linux |
tbkka
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.