[6.2][Concurrency] Account for explicit @concurrent on closures
#81237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If closure is stated as `@concurrent` is has to be treated as nonisolated. Resolves: rdar://150397825 (cherry picked from commit ef65f26)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #81231
Explanation:
If closure is stated as
@concurrentis has to be treated as nonisolated otherwise it could be possible to infer wrong isolation which results in data races.Main Branch PR: [Concurrency] Account for explicit
@concurrenton closures #81231Risk: Low (This is specific to the new
@concurrentwhich nobody should be using yet).Reviewed By: @ktoso @hborla
Resolves: rdar://150397825
Testing: Added new tests to the test suite.
(cherry picked from commit ef65f26)