[Concurrency] Fix issue with using Dispatch queues as executors. #81201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were failing to switch executors to Dispatch queues, where those were being used as executors, which caused a variety of unusual symptoms. rdar://150310927
al45tair
added
🍒 release cherry pick
Contributor
Author
|
Explanation: While rearranging Concurrency I'd inadvertently removed some code that munged Dispatch queue pointers into executor references. It needs to be there in order to support the case where we're using a custom dispatch queue as an executor. |
Contributor
Author
|
@swift-ci Please test |
ktoso
approved these changes
Apr 30, 2025
mikeash
approved these changes
Apr 30, 2025
tbkka
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were failing to switch executors to Dispatch queues, where those were being used as executors, which caused a variety of unusual symptoms.
rdar://150310927