[6.2] SILGen: Fix crash when thrown error type is loadable and has a type parameter #81163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter Fixes swiftlang#74289. Fixes rdar://problem/146677409.
Contributor
Author
|
@swift-ci Please test |
DougGregor
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #81162.
Description: Fixes a crash when a thrown error type is loadable but also contains a type parameter.
Origination: This never worked. I previously fixed an IRGen crash in IRGen: Make sure loadable error types are mapped into the generic environment too #77371, but we'd hit the same SILGen issue in all but the most trivial cases.
Issue: Typed throws that rely on a type's generic placeholder crash the compiler. #74289
Radar: rdar://problem/146677409
Risk: Low.
Reviewed by: @DougGregor