[6.2][cherrypick] Add a platform executor module for OpenBSD. #81152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3405691582
changed the title
Member
Author
|
@swift-ci please test. |
DougGregor
approved these changes
Apr 29, 2025
Member
Author
|
Please merge on my behalf, thank you! |
3405691582
force-pushed
the
platform_executor_62
branch
from
3edd141 to
46c0f4a
Compare
Member
Author
|
@swift-ci please test. |
This is basically the same as the one for Linux, but it would be somewhat awkward to add the platform conditional on a file named for Linux when OpenBSD is not Linux. Important note: if Dispatch is disabled, then this will cause a compilation error (probably not just for OpenBSD either), because PlatformExecutorFactory is both defined in PlatformExecutorNone.swift and PlatformExecutor<...>.swift in this case. Because this only bites OpenBSD bootstrap builds, and since OpenBSD support has been upstreamed to Dispatch, default to the Dispatch implementation for now to get this in, and we'll refactor in a different pr.
3405691582
force-pushed
the
platform_executor_62
branch
from
46c0f4a to
7a87fa5
Compare
Member
Author
|
@swift-ci please test. |
Member
Author
|
Had to rebase to keep sync with the branch. @DougGregor could you enable auto-merge or merge on my behalf when ready? Thanks! |
DougGregor
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a platform executor file for OpenBSD. This cherrypick will help reduce the delta between the branch and an eventual OpenBSD platform port.
Only limited to OpenBSD and the build system.
See OpenBSD port issue in #78437
#80877
Minimal, as changes are limited to OpenBSD only.
Original change has passed CI.
@ktoso
@compnerd
@etcwilde