[cxx-interop] Temporarily exclude CxxSetToCollection benchmark from the build #81145
Conversation
j-hui
left a comment
j-hui
left a comment
There was a problem hiding this comment.
There were a couple others failing too, including VectorSum and StringConversion. Those should probably be commented out too.
egorzhdan
force-pushed
the
egorzhdan/bench-disable
branch
from
7437b2e to
8edd8d2
Compare
…he build This is needed to unblock nightly toolchains, which are currently failing to build with an assertion: ``` swift-frontend: /home/build-user/build/buildbot_linux/llvm-linux-x86_64/tools/clang/include/clang/AST/TypeNodes.inc:79: TypeInfo clang::ASTContext::getTypeInfoImpl(const Type *) const: Assertion `!T->isDependentType() && "should not see dependent types here"' failed. ``` rdar://150067288
egorzhdan
force-pushed
the
egorzhdan/bench-disable
branch
from
8edd8d2 to
85d6be5
Compare
|
@swift-ci please benchmark |
|
@swift-ci please smoke test |
|
@j-hui good point! I disabled the other two, let's see if anything else is failing. |
j-hui
left a comment
j-hui
left a comment
There was a problem hiding this comment.
This looks good to me, but I'm wondering why you're commenting out the contents of the benchmark rather than commenting out the cmake entry (as you were doing originally)?
|
@swift-ci please smoke test macos platform |
1 similar comment
|
@swift-ci please smoke test macos platform |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test macos |
@j-hui the benchmarks can be built as a Swift Package, in which case CMake flags won't be applied. This way we can be certain that the problematic code won't be built regardless of the build system used. |
|
@egorzhdan does this need a cherry-pick for 6.2? |
…k from the build (swiftlang#81145)" This reverts commit 86c30d6.
This is needed to unblock nightly toolchains, which are currently failing to build with an assertion:
rdar://150067288