[6.2] Demangle: Implement missing Node::Kind::DependentProtocolConformanceOpaque #81046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paque If a retroactive conformance is conditional and the subject type of a conditional requirement is an opaque archetype, the mangler would emit a mangling using the "HO" operator which the demangler did not understand. Implement de/remangler support for the "HO" operator. Fixes rdar://149801864.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS |
Contributor
Author
|
macOS PR testing is failing due to an unrelated LLVM issue. |
Contributor
Author
|
@swift-ci Please test macOS |
2 similar comments
Contributor
Author
|
@swift-ci Please test macOS |
Contributor
Author
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2 cherry-pick of #81045
Description: Implement de/remangler support for the "HO" operator.
Scope of the issue: If a retroactive conformance is conditional and the subject type of a conditional requirement is an opaque archetype, the mangler would emit a mangling using the "HO" operator which the demangler did not understand.
Origination: Since Swift 5.1 probably.
Risk: Low, this just adds a case that the demangler rejected before.
Radar: Fixes rdar://149801864.
Reviewed by: @xedin