[6.2] LoadableByAddress: Fix shouldTransformYields to use (properly) substituted types #80989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…substituted types Scope: The LoadableByAddress pass fails on some Swift source because it ignores pattern substitutions. Risk: Low. Many source patterns where this difference matters should have crashed. Fix: Don't ignore pattern substitutions. Testing: The project that crashed no longer does. Unit test added. rdar://149281263 issues/80818 (cherry picked from commit 521fb07)
Contributor
Author
|
@swift-ci test |
slavapestov
approved these changes
Apr 23, 2025
Contributor
Author
|
@swift-ci test windows |
tbkka
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: The LoadableByAddress pass fails on some Swift source because it ignores pattern substitutions.
Risk: Low. Many source patterns where this difference matters should have crashed.
Fix: Don't ignore pattern substitutions.
Testing: The project that crashed no longer does. Unit test added.
mainPR: #80966rdar://149281263
issues/80818