[6.2] Reland #79707 #80956
Merged
[6.2] Reland #79707 #80956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@_transparent will ensure there are inlined in MandatoryInlining which runs before OSLogOptimization.
OSLogOptimization does not look through their calls because they are not marked with
@_semantics("constant_evaluable") which requires them to also be annotated as @_optimize(none)
rdar://148256435
Revert "Merge pull request swiftlang#80767 from meg-gupta/reverttransparent" This reverts commit 198a802, reversing changes made to 8eb43af.
meg-gupta
requested review from
DougGregor,
matthewseaman,
ravikandhadai and
tbkka
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Apr 21, 2025
Contributor
Author
|
Need #80971 for the failing test on macOS |
Contributor
Author
|
@swift-ci test macOS platform |
Member
|
This should have the full template for cherry-picks. Also, it's tracked by rdar://146793956 |
Contributor
Author
|
@DougGregor Updated the PR template for release/6.2 |
DougGregor
approved these changes
Apr 22, 2025
Member
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: #79707 was reverted because it led to missed OSLogOptimization for simple tests under different configuration of stdlib (-Osize/-Onone). This is because stdlib's
FixedWidthInteger.bitwidthand others were not inlined and the optimization missed to determine these calls as constants.This PR brings back #79707 along with #80712 which fixes the exposed issues.
With #80712, stdlib's
FixedWidthInteger.bitwidthand others are marked as@_transparentwhich inlines them inMandatoryInliningwhich happens beforeOSLogOptimization.Main Branch PR: #79707 and #80712
Risk: Medium
Reviewed By: @ravikandhadai
Resolves: rdar://146793956
Testing: CI tests and some internal swift projects.