[🍒: 6.2] Fix Bootstrap: UTF8EncoddingError #80936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass that annotated control-flow positions unreachable after an infinite loop was migrated to pure Swift in PR 79186 (swiftlang#79186). As a result, the C++-only bootstrap compiler is unable to determine that the code-location is unreachable. Placing a fatalError after the infinite while loop. Fixes: rdar://149568740 (cherry picked from commit 783c969)
Member
Author
|
@swift-ci please test |
Contributor
shahmishal
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒#80934
The pass that annotated control-flow positions unreachable after an infinite loop was migrated to pure Swift in PR 79186 (#79186). As a result, the C++-only bootstrap compiler is unable to determine that the code-location is unreachable. Placing a fatalError after the infinite while loop.
Fixes: rdar://149568740
(cherry picked from commit 783c969)
Explanation:
Fixes a regression caught by the bootstrap job. The pass that identifies unreachable code locations using the control-flow-graph was moved to Swift-only, so any code that is required in the bootstrap must explicitly annotate those locations or the code will fail to compile when compiled with the bootstrap compiler.
Risk: Low, the full compiler places an unreachable instruction here at the SIL level under normal circumstances. The bootstrap compiler doesn't have that capability, so we must add one explicitly.
Reviewed By: @xedin
Testing: Locally verified that the bootstrap works after this PR. Standard PR testing passes with this PR. The bootstrapping bot caught the regression.