[6.2] CMake Embedded Stdlib: mark ExecutorImpl.cpp as optional
#80883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for internal Apple configurations that build the Embedded Stdlib on its own. Addresses rdar://149410405 (cherry picked from commit a249e7f)
Contributor
Author
|
@swift-ci please test |
shahmishal
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Mark
ExecutorImpl.cppas optional when building Embedded Stdlib on its ownScope:
Very narrow, this affects internal Apple configurations that builds the Embedded Stdlib without the Darwin one in the same build-script invocation
Issues:
rdar://149410405
Original PRs:
CMake Embedded Stdlib: mark
ExecutorImpl.cppas optional #80866Risk:
Low -- the change effectively tells the underlying CMake logic from LLVM to be more lenient
Testing:
Reviewers:
@al45tair