Skip to content

[DNM][Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set #80738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DNM][Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set #80738

wants to merge 1 commit into from

Conversation

@artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 10, 2025

Instead, Swift overlay dependencies have been getting reported as a separate field for Swift module dependencies and the clients have had sufficient time to begin using it (e.g. swiftlang/swift-driver#1365).

@artemcm
[Dependency Scanning] Remove Swift overlay dependencies from the repo…
3ee7361 
…rted 'direct dependencies' set

Instead, Swift overlay dependencies have been getting reported as a separate field for Swift module dependencies.
@artemcm
Copy link
Contributor Author

artemcm commented Apr 10, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 11, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Apr 14, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 14, 2025

Ah, this requires swiftlang/swift-driver#1869 to land first after all.

@artemcm
Copy link
Contributor Author

artemcm commented Apr 14, 2025

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Apr 14, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Apr 15, 2025

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Apr 16, 2025

@kastiglione any ideas on why this may be failing:

lang/swift/completion/TestSwiftREPLCompletion.py
...
pexpect.exceptions.EOF: End Of File (EOF). Exception style platform.
<pexpect.pty_spawn.spawn object at 0x7f7dcffa7430>

@artemcm
Copy link
Contributor Author

artemcm commented Apr 16, 2025

@swift-ci test Linux platform

@artemcm artemcm changed the title [Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set [DNM][DNM][Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set Apr 16, 2025
@artemcm artemcm changed the title [DNM][DNM][Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set [DNM][Dependency Scanning] Remove Swift overlay dependencies from the reported 'direct dependencies' set Apr 16, 2025
@artemcm artemcm mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

Assignees

No one assigned

Labels

do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemcm @cachemeifyoucan