Skip to content

[6.1] [Stdlib performance] Make integer conversion operations transparent #80077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2025
Merged

[6.1] [Stdlib performance] Make integer conversion operations transparent #80077

merged 4 commits into from
Mar 18, 2025

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Mar 18, 2025 •
edited
Loading

ravikandhadai and others added 2 commits March 17, 2025 17:06
@ravikandhadai @DougGregor
[SILOpt][OSLog] Skip constant folding StaticString in the
34aba08 
OSLogOptimization pass

The OSLogOptimization pass constant evaluates and folds SIL instructions
that are inlined from the construction of the string interpolations passed
to the log calls, which enables replacing the dynamic format string construction
with a static format string. In addition to folding constant strings, it also folds
constant integers and arrays whose elements are constants. This change makes it
skip folding static strings, since they are already efficiently represented.

rdar://146028438
(cherry picked from commit cbf804e)
@DougGregor
[Stdlib performance] Make integer conversion operations transparent
c637e76 
The integer conversion operations were inlinable, but aren't getting
inlined in debug builds, which results in unreasonably poor
performance. Mark them as transparent so we don't end up with
unspecialized generic code in the hot path.

Fixes swiftlang#78501
@DougGregor DougGregor requested a review from a team as a code owner March 18, 2025 00:07
@DougGregor
Copy link
Member Author

DougGregor commented Mar 18, 2025

@swift-ci please test

@DougGregor
Copy link
Member Author

DougGregor commented Mar 18, 2025

@swift-ci please test

@DougGregor DougGregor merged commit 8923a9d into swiftlang:release/6.1 Mar 18, 2025
5 checks passed
@DougGregor DougGregor deleted the integer-conversion-transparent-6.1 branch March 18, 2025 17:02
@DougGregor DougGregor mentioned this pull request Apr 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DougGregor @stephentyrone @ravikandhadai