Ensure we're commuting instructions only when internal one has a single use. #79511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
asl
added
SILOptimizer
Contributor
|
Can you add test cases for this? |
Contributor
Author
Well, the ultimate testcase is in the tree, just requires ownership modules as you mentioned :) Let me see if it would be possible to add SIL-to-SIL negative tests here. |
use. Fix couple of similar single use predicates while there. Fixes #78848
Contributor
Author
|
@eeckstein Added for both interesting cases |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Tagging @JaapWijnen |
Contributor
Author
|
@swift-ci please test windows platform |
Contributor
Author
|
Windows seems to be broken on |
Contributor
Author
|
@swift-ci please test windows platform |
Contributor
Author
|
@eeckstein will you please check when you will have some time? Thanks! |
Contributor
Author
|
@eeckstein ping |
Contributor
Author
|
@eeckstein will you please check when you will have some time? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix couple of similar single use predicates while there.
Fixes #78848