[Frontend] Support -index-store-path for explicit module interface compilation.
#79485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Feb 19, 2025
| // swift-interface-format-version: 1.0 | ||
| // swift-module-flags: -module-name IndexWhileBuilding | ||
|
|
||
| // REQUIRES: OS=macosx |
There was a problem hiding this comment.
Why does the test require macOS?
There was a problem hiding this comment.
Hmm, it shouldn't. I adapted this from test/ModuleInterface/ExplicitInterfaceBuild.swiftinterface, which also claims to require macOS, but I don't see anything in it that should either. Maybe that one was a mis-copy of test/ModuleInterface/ExplicitInterfaceObjc.swiftinterface?
I've removed it from my test; let's see what happens.
allevato
force-pushed
the
index-swiftinterface
branch
from
cea4058 to
5fd9852
Compare
|
@swift-ci please smoke test |
bnbarham
approved these changes
Feb 21, 2025
copybara-service bot
pushed a commit
to bazelbuild/rules_swift
that referenced
this pull request
Mar 31, 2025
Starting with Swift 6.1 (Xcode 16.3), the frontend correctly generates an indexstore from a `.swiftinterface` file when it is build with `-explicit-interface-module-build` (swiftlang/swift#79485). Collect that indexstore if requested. To do this, the worker has to find the `.swiftinterface` file and extract the flags from it in order to pass them to the frontend. For system frameworks, this is a bit more delicate, because we don't know the path to the actual `.swiftinterface` file at analysis time (it may be a _variant_ of the current architecture, like `arm64e` for `arm64`). So we add logic to the worker that infers the right file given the path to the parent `.swiftmodule` directory, using similar logic to the compiler itself. PiperOrigin-RevId: 742225315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.