-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[DebugInfo] Emit debug info for witness tables #79171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DebugInfo] Emit debug info for witness tables #79171
Conversation
|
@swift-ci smoke test |
lib/IRGen/IRGenDebugInfo.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keying this off of depth/index is insufficient. Eg in the following, we pass a witness table for the T.Element: Equatable conformance:
func f<T: Sequence>(_: T) where T.Element: Sequence {}
7cd787f to
f2e2e94
Compare
|
@swift-ci test |
f2e2e94 to
32f2cda
Compare
|
@swift-ci test |
2 similar comments
|
@swift-ci test |
|
@swift-ci test |
32f2cda to
2d034a9
Compare
|
@swift-ci test |
2d034a9 to
d48a30b
Compare
|
@swift-ci test |
d48a30b to
2f59d26
Compare
|
@swift-ci test |
2f59d26 to
126fa9e
Compare
|
@swift-ci test |
2 similar comments
|
@swift-ci test |
|
@swift-ci test |
126fa9e to
c6803d6
Compare
|
@swift-ci test |
c6803d6 to
143f274
Compare
|
@swift-ci test |
143f274 to
331e9e7
Compare
|
@swift-ci test |
331e9e7 to
29c87df
Compare
|
@swift-ci test |
This change emits debug info for witness tables passed into generic functions when a generic type is constrained to a protocol. This information is required for LLDB's generic expression evaluator to work in such functions. rdar://104446865
|
@swift-ci test |
29c87df to
66748f7
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
I think source compatibility passed, I see this at the end of the logs: And later: I'll rerun it just in case though |
|
@swift-ci test source compatibility |
1 similar comment
|
@swift-ci test source compatibility |
|
Looks like source compatibility aborts because of sccache: |
|
Let's merge this and watch the bots closely. Did it pass source-compatibility locally? |
|
@swift-ci test source compatibility |
…table Revert "Merge pull request #79171 from augusto2112/debug-info-witness…
This change emits debug info for witness tables passed into generic functions when a generic type is constrained to a protocol. This information is required for LLDB's generic expression evaluator to work in such functions.
rdar://104446865