[6.1] AliasAnalysis: consider memory effects of a consume/destroy of a class on it's let-fields #78792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jan 21, 2025
eeckstein
commented
- Explanation: Fixes a bug in alias-analysis which can cause a mis-compile by moving a release of an object before the load of a let-field. Although a let-field can never be mutated, a release or consume of the class must be considered as writing to such a field.
- Risk: Low. It's a small change which makes alias-analysis more conservative.
- Testing: Tested by a lit test.
- Issue: rdar://142996449
- Reviewer: @meg-gupta
- Main branch PR: AliasAnalysis: consider memory effects of a consume/destroy of a class on it's let-fields #78754. Note that this only cherry-picks the essential bug-fix commit to reduce the risk.
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Jan 21, 2025
…s on it's let-fields Although a let-field can never be mutated, a release or consume of the class must be considered as writing to such a field. This change removes the special handling of let-fields in two places, where they don't belong. Class fields are handled by ImmutableScope anyway. Handling of global let-variable is temporarily removed by this commit. Fixes a miscompile. rdar://142996449
eeckstein
force-pushed
the
fix-alias-analysis-6.1
branch
from
2a5c5b8 to
ed26847
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.