[CS] Don't simplify FunctionResult in simplifyLocator
#78377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test source compatibility |
Allow `InsertExplicitCall` for e.g converting `() -> () -> Void` to `() -> Void`. No test since it's already covered in the test suite when the next commit is applied.
Simplifying into the function expression is wrong, like `FunctionArgument` this isn't an element that can be simplified. This also means we don't need to handle it in `MissingCallFailure`, since we shouldn't be recording that fix in this case.
The fix is currently unused, and the FailureDiagnostic can be inlined into MissingCallFailure.
hamishknight
force-pushed
the
no-simplify-result
branch
from
8514d7b to
2fd6863
Compare
Contributor
Author
|
@swift-ci please test |
xedin
approved these changes
Jan 2, 2025
This was referenced Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying into the function expression is wrong, like
FunctionArgumentthis isn't an element that can be simplified. Seems like this was a leftover from #31679 before it introduced theUnresolvedMemberChainResultlocator element.While here, remove the unused
AutoClosureForwardingfix.Resolves #78376