[Type checker] Teach areOverrideCompatibleSimple() to look at initializers #7788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test and merge |
Contributor
|
This seems incorrect; what if you have |
…izers. Apply the same is-generic check to initializers that we apply to functions when establishing basic override compatibility. This is a simple optimization for master, but fixes a crasher for Swift 3.1. Fixes SR-4059.
Member
Author
|
@swift-ci please smoke test and merge |
Member
Author
|
This is about the generic parameters on the initializer itself; it's not checking the generic parameters of the enclosing class. You are correct that the implementation is wrong: one could override a concrete initializer with a generic one. But we need a bit more work to get there. |
Member
Author
|
Hmm. Maybe the name |
Member
Author
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same is-generic check to initializers that we apply to
functions when establishing basic override compatibility. This is a
simple optimization for master, but fixes a crasher for Swift 3.1.
Fixes SR-4059