[GenericSigBuilder] Start retaining complete information in the potential archetype graph #7755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an equivalence-class abstraction that captures all of the members of the equivalence class in a separate type that will maintain the "truth" about the meaning of the equivalence class, rather than having that information distributed amongst the potential archetypes within the class. For now, use it to capture the members of the equivalence classes, so we have one SmallVector per equivalence class rather than N SmallVectors.
When we see a second same-type-to-concrete constraint on a particular potential archetype, record it. Previously, we were checking it and then updating the requirement source eagerly. That won't work with proper recursion detection, and meant that we missed out on some obvious redundant-same-type-constraint diagnostics. The scheme here is to build up the equivalence classes without losing any information, and then determine which information is redundant at the end.
Member
Author
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The potential archetype graph is being constructed eagerly and minimized eagerly. While the former is fine (albeit not ideal), the latter is a problem: we might encounter information later that would have changed how minimization behaves. To that end, start to:
EquivalenceClasstype.This improves our diagnosis of redundant same-type-to-concrete constraints somewhat, because we don't lose information. It will also allow us to detect/remove "recursive" implied constraints that shouldn't be there. Eventually.