Sema: TypeRefinementContextBuilder must not skip defer blocks #77333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
swiftlang#76621 caused a regression by skipping the AST nodes nested under `defer` blocks. The node associated with a `defer` block is implicit because it is a kind of closure context synthesized by the compiler. However, the nodes it contains are not implicit and so they must be visited by the `TypeRefinementContextBuilder`. Resolves rdar://139012152
tshortli
force-pushed
the
defer-availability
branch
from
bcfac88 to
85ded85
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76621 caused a regression by skipping the AST nodes nested under
deferblocks. The node associated with adeferblock is implicit because it is a kind of closure context synthesized by the compiler. However, the nodes it contains are not implicit and so they must be visited by theTypeRefinementContextBuilder.Resolves rdar://139012152.