RedundantLoadElimination: support redundant loads of array elements with non-constant index #77228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci benchmark |
atrick
approved these changes
Oct 25, 2024
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Seems like a reasonable approach to me
eeckstein
force-pushed
the
improve-rle
branch
from
81c867e to
bf1a91d
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macos |
eeckstein
force-pushed
the
improve-rle
branch
from
bf1a91d to
3a5f805
Compare
Add `Value.constantAccessPath`. It is like `accessPath`, but ensures that the projectionPath only contains "constant" elements. This means: if the access contains an `index_addr` projection with a non-constant index, the `projectionPath` does _not_ contain the `index_addr`. Instead, the `base` is an `AccessBase.index` which refers to the `index_addr`.
…ith non-constant index
For example:
```
func test3(_ arr: Array<Int>, index: Int) -> Int {
return arr[index] + arr[index]
}
```
rdar://138519664
eeckstein
force-pushed
the
improve-rle
branch
from
3a5f805 to
7786596
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
rdar://138519664