[6.0] Ensure LoadableByAddress rewrites pointer_to_address #77111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the target address is address of tuple type that should be rewritten. Fixes swiftlang#72363 (cherry picked from commit 2ad4a60)
clackary
force-pushed
the
fix/6.0-cherrypick-72619
branch
from
766015e to
1457fe6
Compare
Member
|
@swift-ci please test |
DougGregor
approved these changes
Dec 3, 2024
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
This looks safe enough to take
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicks the fix for the assertion failure from Ensure LoadableByAddress rewrites pointer_to_address #72619 into 6.0 release toolchains.
Looks like this mainly affects autodiff code.
[LoadableByAddr] Assertion failed: (srcAddr->getType() == destAddr->getType()) #72363
Ensure LoadableByAddress rewrites pointer_to_address #72619
Low, the original fix has landed and stuck on main for months.
Includes a test case. No additional testing needed.
@asl
@aschwaighofer