Skip to content

Move TaskLocal.h out of ABI folder #76883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Move TaskLocal.h out of ABI folder #76883

merged 1 commit into from
Oct 10, 2024

Conversation

@nickolas-pohilets
Copy link
Contributor

@nickolas-pohilets nickolas-pohilets commented Oct 6, 2024

This header describes implementation details, that can be changed without breaking ABI.

@nickolas-pohilets nickolas-pohilets force-pushed the mpokhylets/move-task-locals-header branch from 179f815 to cb4c880 Compare October 6, 2024 12:37
@ktoso
Copy link
Contributor

ktoso commented Oct 7, 2024

@swift-ci please test

@ktoso ktoso self-assigned this Oct 7, 2024
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Oct 7, 2024
@nickolas-pohilets
Copy link
Contributor Author

nickolas-pohilets commented Oct 7, 2024 

Test Case '-[SKSupportTests.AsyncUtilsTests testWithTimeout]' started.
/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/sourcekit-lsp/Tests/SKSupportTests/AsyncUtilsTests.swift:22: error: -[SKSupportTests.AsyncUtilsTests testWithTimeout] : failed - Expression was expected to throw but did not throw
Test Case '-[SKSupportTests.AsyncUtilsTests testWithTimeout]' failed (2.805 seconds).

Does not seem to be related to my changes.

@ktoso
Copy link
Contributor

ktoso commented Oct 7, 2024

@swift-ci please smoke test macOS

@nickolas-pohilets
Copy link
Contributor Author

nickolas-pohilets commented Oct 8, 2024

@swift-ci please smoke test macOS

The failed one is a validation test. Did you mean @swift-ci Please test macOS platform?

@ktoso
Copy link
Contributor

ktoso commented Oct 8, 2024

No, the smoke was on purpose. Seems it didn’t complete tho

@ktoso
Copy link
Contributor

ktoso commented Oct 8, 2024

Giving a full run another go…

@ktoso
Copy link
Contributor

ktoso commented Oct 8, 2024

@swift-ci please test macOS

@nickolas-pohilets
Copy link
Contributor Author

nickolas-pohilets commented Oct 10, 2024

@ktoso, can it be merged, or do I need more approvals?

@ktoso ktoso merged commit bd554ba into swiftlang:main Oct 10, 2024
5 checks passed
@ktoso
Copy link
Contributor

ktoso commented Oct 10, 2024

Yes we can merge it, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktoso ktoso ktoso approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun

@hborla hborla Awaiting requested review from hborla

@slavapestov slavapestov Awaiting requested review from slavapestov

@xedin xedin Awaiting requested review from xedin

Assignees

@ktoso ktoso

Labels

concurrency Feature: umbrella label for concurrency language features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickolas-pohilets @ktoso