[Concurrency] Remove C++ runtime references from embedded Concurrency. #76870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rjmccall
approved these changes
Oct 4, 2024
In embedded mode, we mustn't have references to the C++ library, because some embedded platforms don't include the C++ library. Additionally, it's good to avoid use of global operator new and operator delete, because they can be globally overridden and this has bitten us in the past. rdar://137286187
al45tair
force-pushed
the
eng/PR-137286187
branch
from
4e2dc05 to
54a4955
Compare
|
@swift-ci Please smoke test |
|
Looks like some C++ problems to do with the allocator on both Linux and Windows. Will go figure out what changes I need there. |
Seems I forgot some constructors (this was causing build failures on Linux and Windows, but not macOS). rdar://137286187
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In embedded mode, we mustn't have references to the C++ library, because some embedded platforms don't include the C++ library.
Additionally, it's good to avoid use of global operator new and operator delete, because they can be globally overridden and this has bitten us in the past.
rdar://137286187