Set install dir correctly for libSwiftRemoteMirror #76664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
mikeash
approved these changes
Sep 24, 2024
Contributor
mikeash
left a comment
mikeash
left a comment
There was a problem hiding this comment.
Interesting, the SWIFTLIB_DARWIN_INSTALL_NAME_DIR variable never seems to get set anywhere. Leftover from bygone days?
al45tair
approved these changes
Sep 24, 2024
justice-adams-apple
deleted the
install-remote-mirror-in-shared-cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
libswiftRemoteMirrorin shared cache by ensuring the split segment info load command is included in the library.The linker only adds
LC_SEGMENT_SPLIT_INFOif the install name of the library is in/usr/libPreviously,
SWIFTLIB_DARWIN_INSTALL_NAME_DIRwas used incorrectly and not set, meaning the library would default install_name to @rpath/libswiftRemoteMirror.dylib