[test] Update tests for parity with the new driver #76640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer a behavior we have in the new driver (swiftlang/swift-driver#733).
This is only testing legacy driver behaviour. In the new driver, only primary outputs have their outputs deduced from the module name.
The new driver builds a PCH by default, which the old driver didn't do. These tests don't expect a PCH, so avoid building it.
Add `-wmo` to the invocation to ensure we don't end up doing merge-modules, which makes the test consistent across both the old and new driver.
This crashes the new driver (swiftlang/swift-driver#1570).
A couple of tests are expecting merge-modules behaviour, add `-no-emit-module-separately` in those cases to ensure that merge modules is used in both the old and new driver.
The new driver forms additional jobs for the auxiliary outputs here, whereas the old driver would only do a single job. This shouldn't really matter in practice though since we make an effort not to include auxiliary outputs in indexing invocations.
hamishknight
force-pushed
the
driver-parity
branch
from
e0366e9 to
2a5dba6
Compare
CMO is enabled by default in the new driver, add `-enable-default-cmo` in a couple of places to make the behavior consistent across both the old and new driver.
The behavior of these tests varies depending on whether the new or old driver is being used, force the old driver for now.
hamishknight
force-pushed
the
driver-parity
branch
from
2a5dba6 to
8e0407b
Compare
|
@swift-ci please test |
hamishknight
requested review from
QuietMisdreavus,
adrian-prantl,
ahoppen,
bnbarham,
eeckstein,
rintaro and
xymus
as code owners
|
SymbolGraphGen test update looks good. How do you force running tests with the new driver? I'm interested to know so i can double-check during the transition period. |
|
@QuietMisdreavus You can force the new driver by setting |
artemcm
approved these changes
Sep 23, 2024
eeckstein
reviewed
Sep 24, 2024
| // RUN: %target-build-swift -O -wmo -Xfrontend -enable-default-cmo -parse-as-library -emit-tbd -emit-tbd-path %t/ModuleTBD.tbd -emit-module -emit-module-path=%t/ModuleTBD.swiftmodule -module-name=ModuleTBD -package-name Pkg -I%t -I%S/Inputs/cross-module %S/Inputs/cross-module/default-module.swift -c -o %t/moduletbd.o -Xfrontend -tbd-install_name -Xfrontend module | ||
|
|
||
| // RUN: %target-build-swift -O -wmo -module-name=Main -package-name Pkg -I%t -I%S/Inputs/cross-module %s -emit-sil | %FileCheck %s | ||
| // RUN: %target-build-swift -Xfrontend -enable-default-cmo -O -wmo -module-name=Main -package-name Pkg -I%t -I%S/Inputs/cross-module %s -emit-sil | %FileCheck %s |
There was a problem hiding this comment.
Why is this needed? Default CMO should be enabled by default
There was a problem hiding this comment.
The test suite currently uses the old driver, where it's disabled by default
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests such that they run with both the old and new driver in preparation for switching over to the new driver.