Remove swift-indent tool
#76577
Merged
Remove swift-indent tool
#76577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the implementation of the `swift-indent` tool, its associated documentation, and utilities. This tool was never completed and has much better alternatives with `swift-format` which is more flexible and actually maintained.
Member
Author
|
@swift-ci please test |
tshortli
approved these changes
Sep 19, 2024
etcwilde
approved these changes
Sep 19, 2024
Member
etcwilde
left a comment
etcwilde
left a comment
There was a problem hiding this comment.
LGTM.
Do we need a matching patch to the driver repo to update the options there?
Member
Author
|
Yeah, it would be good to update swift-driver as well. |
Member
Author
|
@swift-ci please test Linux platform |
CodaFi
approved these changes
Sep 20, 2024
allevato
added a commit
to allevato/swift-driver
that referenced
this pull request
Oct 9, 2024
This is the companion of swiftlang/swift#76872. I've reused the `SwiftIndentOption` constant, which was removed by swiftlang/swift#76577 (but Options.swift was never updated here to remove it).
artemcm
pushed a commit
to swiftlang/swift-driver
that referenced
this pull request
Oct 18, 2024
This is the companion of swiftlang/swift#76872. I've reused the `SwiftIndentOption` constant, which was removed by swiftlang/swift#76577 (but Options.swift was never updated here to remove it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the implementation of the
swift-indenttool, its associated documentation, and utilities. This tool was never completed and has much better alternatives withswift-formatwhich is more flexible and actually maintained.