[cxx-interop][SwiftCompilerSources] Reduce the number of SWIFT_IMPORT_UNSAFE attributes
#76515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with `SILDebugLocation` `SWIFT_IMPORT_UNSAFE` is an escape hatch that can be used to make the Swift compiler ignore its usual safety heuristics for C++ types. `SILDebugLocation` is better described as a self-contained Swift type. Similar to 35263ef.
…SAFE` `OptionalInt` is not an unsafe type in Swift, so the attribute has no effect.
…SAFE` `swift::Decl` and its inheritors should be treated as foreign reference types in Swift, meaning pointers to them (`Decl*`) should be mapped to Swift classes. This can be done by applying `SWIFT_UNSAFE_REFERENCE` attribute to the `swift::Decl` types. However, at the moment these functions don't seem to be used from Swift, so this change just removes the `SWIFT_IMPORT_UNSAFE` attributes.
…onstructors These attributes have no effect on C++ constructors.
Contributor
Author
|
@swift-ci please smoke test |
eeckstein
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT_IMPORT_UNSAFEis an escape hatch that can be used to make the Swift compiler ignore its usual safety heuristics for C++ types.This removes a few usages of
SWIFT_IMPORT_UNSAFEin SwiftCompilerSources that can be better expressed by other means:SILDebugLocationis better described as a self-contained Swift type.OptionalIntis not an unsafe type in Swift, so the attribute has no effect.swift::Decland its inheritors should be treated as foreign reference types in SwiftSimilar to 35263ef.