[AST] Make IsNonUserModuleRequest consider SourceFile inputs as well.
#76456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
requested review from
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov and
xedin
as code owners
Member
Author
|
@swift-ci please test |
bnbarham
reviewed
Sep 13, 2024
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
Are you able to craft a test case for this at all?
…ell. We're using a small custom frontend tool to generate indexstore data for `.swiftinterface` files in the SDKs. We do this by treating the `.swiftinterface` file as the input of an interface compilation, but this exits early because it treats it as a `SourceFile` instead of an external `LoadedFile`. This happens even if we call `setIsSystemModule(true)` unless we skip setting the SDK path, but that causes other problems. It seems harmless to check for `SourceFile`s as well, so that a tool processing an SDK interface as a direct input still gets the right state.
allevato
force-pushed
the
system-module-check
branch
from
5aa1dd5 to
67d9eec
Compare
Member
Author
Added |
Member
Author
|
@swift-ci please smoke test |
bnbarham
approved these changes
Sep 18, 2024
| @@ -0,0 +1,21 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: %empty-directory(%t/SDK) | |||
| // RUN: cp %s %t/SDK/FakeSystemModule.swift | |||
Contributor
There was a problem hiding this comment.
Could use split-file here instead, but... doesn't really matter I suppose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using a small custom frontend tool to generate indexstore data for
.swiftinterfacefiles in the SDKs. We do this by treating the.swiftinterfacefile as the input of an interface compilation, but this exits early because it treats it as aSourceFileinstead of an externalLoadedFile. This happens even if we callsetIsSystemModule(true)unless we skip setting the SDK path, but that causes other problems. It seems harmless to check forSourceFiles as well, so that a tool processing an SDK interface as a direct input still gets the right state.