StaticInitCloner: skip begin_access instructions when cloning the initial value of a global #76448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
atrick
reviewed
Sep 13, 2024
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
There should at least be an assert somewhere that there aren't any scoped instructions in the initializer
Contributor
Author
|
We can add this to the verifier. But in this case, the cloner is not copying from a global's init value but from the global initializer function. |
Contributor
Author
|
@swift-ci test windows |
Contributor
I would put the assert in StaticInitCloner itself, which only handles init values, rather than assuming the check in this PR is complete. Presumably it's fine for the initializer function itself to have scoped instructions. |
…tial value of a global Fixes a crash when simplifying a load of an UnsafePointer-global which points to another global. rdar://135223354
eeckstein
force-pushed
the
fix-static-init-cloner
branch
from
eeb1506 to
0ee51e4
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
okay, I added an assert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when simplifying a load of an UnsafePointer-global which points to another global.
rdar://135223354